Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mm102 homepage background image #14

Merged
merged 5 commits into from
Aug 1, 2024

Conversation

claudiaGiancola
Copy link
Collaborator

Description of changes - what did you do

Created new .tsx component "DisplayBgImage" to get the “picture of the day” and display it as background image of the Home.tsx component.

It's done applying "display: grid" on the main element of the Home body, so that then the content (content has to be put inside the

) appears as overlayed above the background image (main is the parent, content and background img are its children).

Things to Check

  • [ ok ] Have all the requirements of your ticket have been met
  • [ n/a ] Have you added tests if needed for your ticket
  • [ n/a ] Are all the tests passing

Copy link
Contributor

@Kiran-R-K Kiran-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking really good - I have a couple of renaming requests, let me know when you've done them and I can re-review

src/App.tsx Show resolved Hide resolved
src/Home/Home.tsx Outdated Show resolved Hide resolved
src/images/DisplayBgImage.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@Kiran-R-K Kiran-R-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really good job

@claudiaGiancola claudiaGiancola merged commit e218254 into main Aug 1, 2024
1 check passed
@claudiaGiancola claudiaGiancola deleted the mm102-homepage-background-image branch August 1, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants